| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Reporting query on crash even if completed |
| Date: | 2017-09-18 16:12:12 |
| Message-ID: | CA+TgmoYV+vfOGAU7kXm20AP8MSWkEgfWW=E8gFLS3esJdxWa_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 18, 2017 at 9:47 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Now, for pg_stat_activity part of the argument why this wouldn't be
> confusing was that you could also see the "state" field. Maybe we
> should try to shoehorn equivalent info into the crash log entry?
Yeah, I think so. Really, I think this is an inadvertency, and thus a
bug. But instead of just not showing the query when the backend is
idle, I'd change the display for that case to:
DETAIL: Failed process was idle; last query was: %s
Or something like that. I guess we'd need another case for a backend
that crashed without ever running a query.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-18 16:16:42 | Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup. |
| Previous Message | Tom Lane | 2017-09-18 15:50:06 | src/test/subscription/t/005_encoding.pl is broken |