Re: refactoring basebackup.c

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Subject: Re: refactoring basebackup.c
Date: 2021-11-08 21:41:22
Message-ID: CA+TgmoYT8C6R1xw34EjjJtca4m_bO-LNAto-6Comhn3u9yv=PA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 8, 2021 at 11:34 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Anyway, here's my proposal for fixing the issue immediately before us.
> 0001 adds logic to pad out the unterminated tar archives, and 0002
> makes the server terminate its tar archives while preserving the logic
> added by 0001 for cases where we're talking to an older server. I
> assume that it's best to get something committed quickly here so will
> do that in ~4 hours if there are no major objections, or sooner if I
> hear some enthusiastic endorsement.

I have now committed 0001 and will wait to see what the buildfarm
thinks about that before doing anything more.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-11-08 21:50:25 Re: [PATCH] postgres_fdw: suppress explicit casts in text:text comparisons (was: column option to override foreign types)
Previous Message Stephen Frost 2021-11-08 20:44:50 Re: [PATCH v2] use has_privs_for_role for predefined roles