Re: Parallel Seq Scan vs kernel read ahead

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel Seq Scan vs kernel read ahead
Date: 2020-06-22 19:32:59
Message-ID: CA+TgmoYS6109DHMpa8VG=PmgX8UTSm=83RbCNtXr9G9j0A2paQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ranier,

This topic is largely unrelated to the current thread. Also...

On Mon, Jun 22, 2020 at 12:47 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> Questions:
> 1. Why acquire and release lock in retry: loop.

This is a super-bad idea. Note the coding rule mentioned in spin.h.
There are many discussion on this mailing list about the importance of
keeping the critical section for a spinlock to a few instructions.
Calling another function that *itself acquires an LWLock* is
definitely not OK.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-06-22 20:01:22 Re: More tzdb fun: POSIXRULES is being deprecated upstream
Previous Message Robert Haas 2020-06-22 19:28:14 Re: Default setting for enable_hashagg_disk