From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: moving some code out of explain.c |
Date: | 2025-02-27 18:24:20 |
Message-ID: | CA+TgmoYRpVzHkscvGH-rvT273SNCXO70U_yBB1Rty7KO_N5eQg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 18, 2025 at 1:11 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Tue, Feb 18, 2025 at 1:04 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > I think in cases like this there is a tendency to want to achieve an
> > even split of the original file, but in practice I think that tends
> > not to be difficult to achieve. These two patches combined move about
> > 1000 lines of code into separate files, which I think is actually
> > quite a good result for a refactoring of this sort. We might want to
> > split it up even more, but I don't feel like that has to be done in
> > the first set of patches or that all such patches have to come from
> > me. So I propose to do just this much for now.
> >
> > Comments?
>
> Seems like a good idea to me.
Thanks for the quick response! I have committed these patches.
I see that the Redis-FDW test is failing; it will now need to include
"commands/explain_format.h" -- unless we something, of course.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2025-02-27 18:26:37 | Re: Improve documentation regarding custom settings, placeholders, and the administrative functions |
Previous Message | Peter Geoghegan | 2025-02-27 18:23:57 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |