| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should TIDs be typbyval = FLOAT8PASSBYVAL to speed up CREATE INDEX CONCURRENTLY? |
| Date: | 2015-12-11 17:13:02 |
| Message-ID: | CA+TgmoYQXUG+ED6gi+hx+Gbt--EUy39hfAtYf9LLr0MJY4Kgrw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 9, 2015 at 8:16 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Tue, Nov 17, 2015 at 7:33 PM, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
>> I'm willing, but I'm too new to the codebase to be an effective reviewer
>> (without guidance). The one thing I can offer in the mean time is this: my
>> company/client nearly always has a few spare AWS machines on the largish
>> side where I can compile uncommitted patches and benchmark stuff for y'all.
>
> I think that this particular patch is close to being a slam-dunk, so I
> don't think it's particularly needed here. But thanks.
It never hurts to have a few extra performance test results - I'm all
in favor of Corey doing some testing.
Also, I'd be in favor of you updating the patch to reflect the
comments from Tom and Simon on November 17th.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-12-11 17:34:56 | Re: [HACKERS] max_worker_processes on the standby |
| Previous Message | Robert Haas | 2015-12-11 17:07:57 | Re: [PROPOSAL] VACUUM Progress Checker. |