| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Thom Brown <thom(at)linux(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Introduce replication slots. |
| Date: | 2014-03-03 12:26:56 |
| Message-ID: | CA+TgmoYNC4yPUJmbuP0+P-nzjgc3GPDgjwC+JwxCSFtTjdDAWw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Feb 28, 2014 at 2:22 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> So now that I've actually gone to use physical replication slots, I can't
>> get them working.
>
> Aw yuck. Try a shorter name. libpqrcv_startstreaming is truncating the
> identifier if it's too long...
>
> Patch fixing that attached.
Committed, although I wonder if we shouldn't be doing something more
sophisticated here to avoid the need to guess how long the command
could be. Like, maybe using psprintf()?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-03-03 18:04:36 | pgsql: pg_dump et al: Add --if-exists option |
| Previous Message | Robert Haas | 2014-03-03 12:25:47 | pgsql: Use a longer buffer in libpqrcv_startstreaming. |