| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Antonin Houska <antonin(dot)houska(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> |
| Subject: | Re: bgworker crashed or not? |
| Date: | 2014-05-07 21:45:38 |
| Message-ID: | CA+TgmoYMwCEHPMFncQApBTj0VsjFSty0k1RaktNA+2PLG9u8eA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 7, 2014 at 4:55 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>> This isn't done yet.
>
> Unless I am missing something this change was included in every patch I sent
> - setting rw->rw_terminate = true; in CleanupBackgroundWorker for zero exit
> code + comment changes. Or do you have objections to this approach?
>
> Anyway missing parts attached.
It was, but I felt that the different pieces of this should be
separated into separate commits, and (regardless of how I committed
it) I needed to review each change separately. I wasn't saying it was
your fault that it wasn't done; just that I hadn't gotten it committed
yet.
I've pushed your rebased patch now with some further kibitzing,
especially in regards to the documentation.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-05-07 21:48:15 | Re: pg_shmem_allocations view |
| Previous Message | Peter Geoghegan | 2014-05-07 21:30:45 | Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers |