Re: the s_lock_stuck on perform_spin_delay

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andy Fan <zhihuifan1213(at)163(dot)com>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: the s_lock_stuck on perform_spin_delay
Date: 2024-01-12 15:45:33
Message-ID: CA+TgmoYJoFsn3Mqhj0_0HNgVjtPfahJMgF2Pb7wzDcRFvZuK9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 10, 2024 at 10:17 PM Andy Fan <zhihuifan1213(at)163(dot)com> wrote:
> fixed in v2.

Timing the spinlock wait seems like a separate patch from the new sanity checks.

I suspect that the new sanity checks should only be armed in
assert-enabled builds.

I'm doubtful that this method of tracking the wait time will be
accurate. And I don't know that we can make it accurate with
reasonable overhead. But I don't think we can assume that the time we
tried to wait for and the time that we were actually descheduled are
the same.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-01-12 15:46:50 Re: tablecmds.c/MergeAttributes() cleanup
Previous Message Tom Lane 2024-01-12 15:42:45 Re: tablecmds.c/MergeAttributes() cleanup