Re: Jsonb: jbvBinary usage in the convertJsonbValue?

On Thu, May 29, 2014 at 7:34 AM, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
> I'm little confused by the convertJsonbValue functon at jsonb_utils.c
> Maybe I misunderstood something, so I need help =)
>
>>>> if (IsAJsonbScalar(val) || val->type == jbvBinary)
>>>> convertJsonbScalar(buffer, header, val);
>
> As I can see, the convertJsonbScalar function is used for scalar and binary
> jsonb values. But this function doesn't handle the jbvBinary type.

There definitely seems to be an oversight here of some kind. Either
convertJsonbValue() shouldn't be calling convertJsonbScalar() with an
object of type jbvBinary, or convertJsonbScalar() should know how to
handle that case.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company