| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to improve a few appendStringInfo* calls |
| Date: | 2015-12-21 12:58:18 |
| Message-ID: | CA+TgmoYG613U4ds2=bnB3dx2m20dwf-CaBQ0q2Kq_hZwrgU42g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 2, 2015 at 6:08 AM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> I left out the changes like
>>
>>> - appendStringInfoString(&collist, buf.data);
>>> + appendBinaryStringInfo(&collist, buf.data, buf.len);
>>
>>
>> because they're not an improvement in readablity, IMHO, and they were not
>> in performance-critical paths.
>
> Perhaps we can come up with appendStringInfoStringInfo at some later date.
concatenateStringInfo?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-12-21 13:00:07 | Re: Odd behaviour of SELECT ... ORDER BY ... FOR UPDATE |
| Previous Message | Robert Haas | 2015-12-21 12:54:43 | Re: ToDo list update for BRIN indexes |