Re: [sqlsmith] crash in RestoreLibraryState during low-memory testing

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [sqlsmith] crash in RestoreLibraryState during low-memory testing
Date: 2017-10-04 19:21:04
Message-ID: CA+TgmoYFUeN_ifa9w0GccT+-NOXB=LpQPDixF+2wR9U-sy0PDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 3, 2017 at 3:04 AM, Andreas Seltenreich <seltenreich(at)gmx(dot)de> wrote:
> Tom Lane writes:
>> Presumably somebody could dig into the libc source code and prove or
>> disprove this, though it would sure help to know exactly what platform
>> and version Andreas is testing on.
>
> This is the code in glibc-2.24 around the crash site:
>
> ,----[ glibc-2.24/elf/dl-load.c:442 ]
> | to_free = cp = expand_dynamic_string_token (l, cp, 1);
> |
> | size_t len = strlen (cp);
> `----
>
> …while expand_dynamic_string_token will indeed return NULL on a failed
> malloc. Code in the most recent glibc looks the same, so I'll carry
> this issue over to the glibc bugzilla then.

You know, I was pretty impressed with sqlsmith when it was only
finding bugs in PostgreSQL. Finding bugs in glibc is even more
impressive.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2017-10-04 19:36:24 Re: Possible SSL improvements for a newcomer to tackle
Previous Message Pavel Stehule 2017-10-04 19:20:15 Re: why subplan is 10x faster then function?