| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |
| Date: | 2018-03-24 11:58:30 |
| Message-ID: | CA+TgmoY9-kDOfojw_9BKgH=jVD2Ht_g2yXS8cOWEu4T_xpq4Hg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 24, 2018 at 7:42 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> I suggest we focus on the engineering. I've not discussed this patch
> with Pavan offline.
Well then proposing to commit moments after it's been posted is
ridiculous. That's exactly the opposite of "focusing on the
engineering".
This is a patch about which multiple people have expressed concerns.
You're trying to jam a heavily redesigned version in at the last
minute without adequate review. Please don't do that.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2018-03-24 12:11:27 | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |
| Previous Message | Simon Riggs | 2018-03-24 11:42:47 | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |