| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Wait free LW_SHARED acquisition - v0.2 |
| Date: | 2014-10-08 17:13:33 |
| Message-ID: | CA+TgmoY9+bE6Zpz9goRNHnOXsXEw51jv-eptK+AdoLL4rrmhHQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 8, 2014 at 8:47 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> I don't see that as being relevant. The difference is an instruction or
> two - in the slow path we'll enter the kernel and sleep. This doesn't
> matter in comparison.
> And the code is *so* much more readable.
I find the slist/dlist stuff actually quite difficult to get right
compared to a hand-rolled linked list. But the really big problem is
that the debugger can't do anything useful with it. You have to work
out the structure-member offset in order to walk the list and manually
cast to char *, adjust the pointer, and cast back. That sucks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-10-08 17:20:16 | Re: Wait free LW_SHARED acquisition - v0.2 |
| Previous Message | Paweł Cesar Sanjuan Szklarz | 2014-10-08 16:13:34 | Re: Context lenses to set/get values in json values. |