| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: vacuum_truncate configuration parameter and isset_offset |
| Date: | 2025-03-24 17:43:58 |
| Message-ID: | CA+TgmoY8uZ9-KrZhMw_bbmY5m9_9iUS0jqY951W5NVM0fFJbSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 24, 2025 at 1:27 PM Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
> > > You've just changed the whole engine, for what is seems to be an
> > > exceptional case, that can be solved via existing means.
> > I have not changed the whole engine. I have added an optional integer
> > field to a single struct.
>
> That potentially changes the behaviour of all boolean options. They will never
> be what they were before.
If you want to convince people to change something, you need to make
real arguments, not just wildly accuse Nathan of having broken
everything. He has not "changed the behavior of the whole engine," and
this does not change the behavior of any Boolean options that don't
elect to use it. It is of course possible that there is some better
way to solve the problem than what Nathan picked, but this is really a
very minor code change that appears to solve the problem in a very
natural way.
I don't understand why you're upset about this, and I don't think it's
fair to beat up Nathan for doing something that looks totally normal
without a really clear reason.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-03-24 17:47:50 | Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints |
| Previous Message | David G. Johnston | 2025-03-24 17:37:50 | Re: vacuum_truncate configuration parameter and isset_offset |