From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
Date: | 2017-02-03 14:49:27 |
Message-ID: | CA+TgmoY8krBpfSgn+g=WgcPQ6YNa6LixyhT5nHXtCQ9RHC2nrg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Feb 2, 2017 at 11:16 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'm about to push a fix that removes the crashes (or at least the ones
>>> I see on dromedary),
>
>> For comparison, a patch I wrote by inspection is attached.
>
> Hm, some of what you have here matches what I just pushed, but not all.
>
> I just made the C code agree with what the SQL declarations for the
> functions say.
Doesn't look like it to me. You changed a bunch of places that say
UInt32GetDatum to UInt64GetDatum, but the SQL type certainly isn't
unsigned.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2017-02-03 14:50:38 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
Previous Message | Tom Lane | 2017-02-03 14:43:33 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2017-02-03 14:50:38 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
Previous Message | Tom Lane | 2017-02-03 14:43:33 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |