Re: On disable_cost

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: On disable_cost
Date: 2024-06-28 15:46:24
Message-ID: CA+TgmoY7kBhu1ykintHQd-NmpFS=TqmuH=gcn9ZQ-Y5OSyH+8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 12, 2024 at 11:35 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Well, that didn't generate much discussion, but here I am trying
> again. Here I've got patches 0001 and 0002 from my previous posting;
> I've dropped 0003 and 0004 from the previous set for now so as not to
> distract from the main event, but they may still be a good idea.
> Instead I've got an 0003 and an 0004 that implement the "count of
> disabled nodes" approach that we have discussed previously. This seems
> to work fine, unlike the approaches I tried earlier. I think this is
> the right direction to go, but I'd like to know what concerns people
> might have.

Here is a rebased patch set, where I also fixed pgindent damage and a
couple of small oversights in 0004.

I am hoping to get these committed some time in July. So if somebody
thinks that's too soon or thinks it shouldn't happen at all, please
don't wait too long to let me know about that.

Thanks,

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v3-0001-Remove-grotty-use-of-disable_cost-for-TID-scan-pl.patch application/octet-stream 8.4 KB
v3-0004-Show-number-of-disabled-nodes-in-EXPLAIN-ANALYZE-.patch application/octet-stream 13.5 KB
v3-0002-Rationalize-behavior-of-enable_indexscan-and-enab.patch application/octet-stream 13.1 KB
v3-0003-Treat-number-of-disabled-nodes-in-a-path-as-a-sep.patch application/octet-stream 70.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2024-06-28 18:27:46 Re: Improve EXPLAIN output for multicolumn B-Tree Index
Previous Message Andrei Lepikhov 2024-06-28 14:14:53 Re: Check lateral references within PHVs for memoize cache keys