| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use outerPlanState() consistently in executor code |
| Date: | 2015-04-30 12:46:55 |
| Message-ID: | CA+TgmoY5zMeVx3WsvbvxXFUte5iURwA1RjtuT=+uYuSFJ=FpNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 15, 2015 at 3:38 PM, Qingqing Zhou
<zhouqq(dot)postgres(at)gmail(dot)com> wrote:
> In executor context, outerPlanState(node) is the same as
> node->ss.ps.lefttree. We follow this in most places except a few. This
> patch clean up the outliers and might save us a few instructions by
> removing indirection.
>
> Most of changes are trivial. Except I take out an outerPlan nullable
> check in grouping iterator - as a it surely has a left child.
I don't see any particular reason not to do this.
The patch is weird, though. If I open it with "less", I get binary
garbage. My Mac's TextEdit app opens it OK though.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-04-30 12:51:42 | Re: configure can't detect proper pthread flags |
| Previous Message | Pavel Stehule | 2015-04-30 12:46:13 | Re: Loss of some parts of the function definition |