| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Greg S <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Freeze avoidance of very large table. |
| Date: | 2016-03-09 18:37:50 |
| Message-ID: | CA+TgmoY5EK7=DeWVT3OZE-3ONqgd5e_rbuNQML+pTVrTK2tuDQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 9, 2016 at 9:09 AM, Masahiko Sawada
<sawada(dot)mshk(at)gmail(dot)com> wrote: Attached latest 2 patches.
> * 000 patch : Incorporated the review comments and made rewriting
> logic more clearly.
That's better, thanks. But your comments don't survive pgindent.
After running pgindent, I get this:
+ /*
+ * These old_* variables point to old visibility map page.
+ *
+ * cur_old : Points to current position on old
page. blkend_old :
+ * Points to end of old block. break_old : Points to
old page break
+ * position for rewriting a new page. After wrote a
new page, old_end
+ * proceeds rewriteVmBytesPerPgae bytes.
+ */
You need to either surround this sort of thing with dashes to make
pgindent ignore it, or, probably better, rewrite it using complete
sentences that together form a paragraph.
+ Oid pg_database_oid; /* OID of
pg_database relation */
Not used anywhere?
Instead of vm_need_rewrite, how about vm_must_add_frozenbit?
Can you explain the changes to test.sh?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2016-03-09 19:12:35 | Re: extend pgbench expressions with functions |
| Previous Message | Robert Haas | 2016-03-09 18:30:50 | Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied” |