Re: Proposal for changes to recovery.conf API

On Thu, Dec 1, 2016 at 7:31 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> * Move recovery.conf parameters into postgresql.conf
> Allow reload of most parameters, allow ALTER SYSTEM
> Provide visibility of values through GUC interface

+1.

> * recovery.conf is replaced by recovery.trigger -> recovery.done

+1.

> * pg_basebackup -R
> will write recovery.trigger to data directory
> insert parameters postgresql.conf.auto, if possible

Don't understand that last line; otherwise, +1.

> * backwards compatibility - read recovery.conf from $DATADIR -
> presence of recovery.conf will cause ERROR

+1.

> * backwards compatibility - some parameter names will change, so
> allows others to changes also if needed

Don't understand this.

> * Add docs: "Guide to changes in recovery.conf in 10.0"

Hmm, we don't usually write the docs in terms of how things are
different from a previous version. Might seem strange in 5 years.
Not sure what's best, here.

> * recovery_target as a single parameter, using proposed "xid 666"
> "target value" format

+1.

> * remove hot_standby parameter altogether, in line with earlier changes

That seems a little surprising. We don't think anyone ever wants to
refuse connections during archive recovery?

> * trigger_file renamed to promote_trigger_file

Why?

> * standby_mode = on| off -> default to on

+1.

> * pg_ctl recover - not as part of this patch

+1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company