Re: [sqlsmith] Failed assertion in BecomeLockGroupLeader

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [sqlsmith] Failed assertion in BecomeLockGroupLeader
Date: 2016-05-02 16:25:44
Message-ID: CA+TgmoY4BpPEtmP8q3P3WbEpjE1t_7DUs4wdq=Y_GQhw2iT6Kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 29, 2016 at 9:45 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It will
>> be helpful if you can find the offending query or plan corresponding to it?
>
> I presume the lack of debug_query_string data is because nothing is
> bothering to set debug_query_string in a worker process. Should that be
> remedied? At the very least set it to "worker process", but it might be
> worth copying over the full query from the parent side.

I agree. I thought about doing that at one point, but I didn't quite
have the cycles and I wasn't sure how important it would be. The fact
that we're already hitting cases like this before we've even gone to
beta suggests that it's pretty important. I think it's worth the
extra cycles, even in non-cassert builds. Compared to the overhead of
cajoling the postmaster to fork a new process, the cost of this should
be trivial.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-05-02 16:29:45 Re: [BUGS] Breakage with VACUUM ANALYSE + partitions
Previous Message Oleksandr Shulgin 2016-05-02 16:22:40 Re: Add jsonb_compact(...) for whitespace-free jsonb to text