From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Allow extensions to add new backup targets. |
Date: | 2022-03-16 13:52:41 |
Message-ID: | CA+TgmoY33KQy61JQREnnxKHnyiVnnarGQUFZqAhvbBdXSBMCqQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Wed, Mar 16, 2022 at 5:36 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> I have noticed that this commit produces a warning when building with
> MSVC, as of the end of BaseBackupGetTargetHandle() when the target
> cannot be found. I guess that you'd better add a fake return NULL to
> keep such compilers quiet about that, like that:
> +++ b/src/backend/replication/basebackup_target.c
> @@ -144,6 +144,9 @@ BaseBackupGetTargetHandle(char *target, char *target_detail)
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> errmsg("unrecognized target: \"%s\"", target)));
> +
> + /* keep compiler quiet */
> + return NULL;
> }
Done.
It sucks that I keep missing this point. And it also sucks that we
have to have this kind of stuff. :-(
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2022-03-16 14:29:17 | Re: pgsql: Fix pg_basebackup with in-place tablespaces. |
Previous Message | Robert Haas | 2022-03-16 13:52:05 | pgsql: Suppress compiler warnings. |