| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make relfile tombstone files conditional on WAL level |
| Date: | 2022-01-06 13:52:01 |
| Message-ID: | CA+TgmoY2uU4H2QrziY+E8E+y-JVyppwoW85CimA6ccb3qcqPEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 6, 2022 at 3:47 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Another problem is that relfilenodes are normally allocated with
> GetNewOidWithIndex(), and initially match a relation's OID. We'd need
> a new allocator, and they won't be able to match the OID in general
> (while we have 32 bit OIDs at least).
Personally I'm not sad about that. Values that are the same in simple
cases but diverge in more complex cases are kind of a trap for the
unwary. There's no real reason to have them ever match. Yeah, in
theory, it makes it easier to tell which file matches which relation,
but in practice, you always have to double-check in case the table has
ever been rewritten. It doesn't seem worth continuing to contort the
code for a property we can't guarantee anyway.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Finnerty, Jim | 2022-01-06 13:55:55 | Re: ICU for global collation |
| Previous Message | Joel Jacobson | 2022-01-06 13:28:10 | Re: pl/pgsql feature request: shorthand for argument and local variable references |