From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Speed up in-memory tuplesorting. |
Date: | 2012-02-15 20:54:14 |
Message-ID: | CA+TgmoY+bMBCMsSrRk1DyJsMVszJv8N6pZxa05vA6pzF8QFybA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Feb 15, 2012 at 2:54 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Feb 15, 2012 at 2:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>> Speed up in-memory tuplesorting.
>>
>> This patch appears to have broken those members of the buildfarm that
>> use VPATH builds. I assume you didn't think about the path to
>> qsort_tuple.c very carefully.
>
> So it appears. I copied the rule that modifies errcodes.h, but clearly
> that's not enough. I think I might need to steal and adapt the
> following logic from src/backend/catalog/Makefile:
>
> # locations of headers that genbki.pl needs to read
> pg_includes = -I$(top_srcdir)/src/include/catalog
> -I$(top_builddir)/src/include/catalog
>
> I'll go test that now.
Nope, that's not it. Committed what seems to be the correct fix,
after testing it locally.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-02-15 21:19:10 | pgsql: Run a portal's cleanup hook immediately when pushing it to FAILE |
Previous Message | Robert Haas | 2012-02-15 20:54:04 | pgsql: Fix VPATH builds, broken by my recent commit to speed up tupleso |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-02-15 21:11:43 | Re: Command Triggers |
Previous Message | Jay Levitt | 2012-02-15 20:34:49 | Designing an extension for feature-space similarity search |