| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: moving some code out of explain.c |
| Date: | 2025-02-27 21:25:39 |
| Message-ID: | CA+TgmoY+8MA1AkzLM7MiR7+yUDoT8b6r2OvVz_QF7j64C3WSHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 27, 2025 at 4:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> +1, but how about explain_dr.h too? It doesn't seem though that
> we can avoid #include "executor/instrument.h" there, so it'd be
> a little asymmetrical. But the executor inclusion doesn't seem
> nearly as much almost-circular.
OK, here is v2. One slightly unfortunate thing about this is that we
end up with a line that is over 80 characters:
extern DestReceiver *CreateExplainSerializeDestReceiver(struct
ExplainState *es);
Aside from perhaps shortening the function name, I don't see how to avoid that.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Avoid-including-explain.h-in-explain_format.h-and.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Alsup | 2025-02-27 21:26:21 | Re: Update docs for UUID data type |
| Previous Message | Robert Haas | 2025-02-27 21:12:19 | Re: [PROPOSAL] : Disallow use of empty column name in (column_name '') in ALTER or CREATE of foreign table. |