Re: [GSoC] current working status

Hi Aleksander,

I saw the list of errors you posted. That's because I have some new
function implemented and pushed without testing(in order forget my change
in local machine).
So you are saying it is best to keep each commit workable. Right?

Thanks Charles.

2018-06-14 1:41 GMT-07:00 Aleksander Alekseeev <a(dot)alekseev(at)postgrespro(dot)ru>:

> Hello Charles,
>
> > The first evaluation is coming. Here is my progress so far. During
> > the first stage of work, I have implemented the thrift binary
> > protocol as the format of postgresql plugin. Currently, the main
> > interface is byte. Users who use this plugin need to provide thrift
> > bytes to the plugin, and there are helpers for each data type to
> > parse out the value contained in the bytes. This method has been
> > verified by the use of several unit tests. However, the current
> > interface needs users understand thrift format very well to use this
> > plugin. After discussing with my mentors, it will be more useful to
> > implement the concept of "thrift type", which is a custom type where
> > user provides user understandable format(e.g., json), then the plugin
> > converts into byte. I am currently busy with implementing this
> > feature and still need sometime to complete it. If this part is done,
> > I will go ahead to implement thrift compact protocol. Let me know if
> > you have comments. You can always track the progress from github
> > ( https://github.com/charles-cui/pg_thrift)
>
> Thanks for keeping us informed!
>
> Unfortunately I'm having difficulties compiling your code on Linux with
> PostgreSQL 10.4 or 11 and GCC 8.1.1. Here is a full list of warnings
> and errors: https://afiskon.ru/s/6e/edbefe818e_pg-thrift-errors.txt
>
> I also tried a VM with Ubuntu 16.04, PostgreSQL 9.6 and GCC 5.4.0. No
> luck either. Please make sure that your code compiles on Linux. Users
> will most likely try to run it on this OS.
>
> It might be also a good idea to add your repository to travic-ci.org
> service.
>
> --
> Best regards,
> Aleksander Alekseev
>