Re: pgAdmin4 - Tree view icons for final reveiw

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>, Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com>, Shirley Wang <swang(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin4 - Tree view icons for final reveiw
Date: 2017-09-11 08:52:32
Message-ID: CA+OCxozzqCRZNfy666FKD_NJ3eOh9OXYEW-FtMb0QK5cOsF2RA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Sep 11, 2017 at 9:19 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> On Mon, Sep 11, 2017 at 1:46 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Please find the attached patch for not showing icons for menu items.
>> I have not completely removed it, but - commented the code (will remove
>> it in final patch).
>>
> We will need to remove the icons from the individual modules later as
> final solution.
>

Yes - please ensure that's done ASAP so we don't forget.

In the meantime, patch applied.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-09-11 08:54:01 Re: Build failed in Jenkins: pgadmin4-master-python26 #436
Previous Message Dave Page 2017-09-11 08:51:52 pgAdmin 4 commit: Remove icons from the menus to de-clutter the UI and