Hi
On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch for Feature #3388 Allow to set the connection
> timeout on the server properties dialog. Please review it.
>
I took a quick look at this and had some questions/comments:
- Doc updates seem to be missing.
- The timeout should be passed through to external utilities like
pg_dump/pg_restore.
- Can/should the timeout be extended to the SSH tunnels?
- Any refactoring opportunities in the code you're touching?
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company