Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog
Date: 2018-06-18 17:09:04
Message-ID: CA+OCxozvzpGn2QQnutxLwAhV8Ag1Aze-jGn9EtuEQiuGS89YYw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch for Feature #3388 Allow to set the connection
> timeout on the server properties dialog. Please review it.
>

I took a quick look at this and had some questions/comments:

- Doc updates seem to be missing.

- The timeout should be passed through to external utilities like
pg_dump/pg_restore.

- Can/should the timeout be extended to the SSH tunnels?

- Any refactoring opportunities in the code you're touching?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-06-18 17:43:15 pgAdmin 4 commit: Ensure that template0 and template1 are available as
Previous Message pgAdmin 4 Jenkins 2018-06-18 16:56:26 Jenkins build is back to normal : pgadmin4-master-python33 #664