From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action |
Date: | 2017-11-20 13:31:13 |
Message-ID: | CA+OCxozvdQVpALBPb-+A6xszX5adT46XWfWRd_Bqz33yUs8esw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Fri, Nov 17, 2017 at 10:30 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA updated.
>
> On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to make error message uniform for 'Create schema' in
>>> both query tool and create schema dialog.
>>> RM#2094
>>>
>>
>> The error message is definitely an improvement, but the dialogue title
>> needs work:
>>
>> Error saving properties: GONE
>>
>> Why does it have : GONE on the end? That seems unhelpful.
>>
> That's coming from ajax statusText
> <https://developer.mozilla.org/en-US/docs/Web/API/Response/statusText>, I
> thought it was intended.
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin 4 Jenkins | 2017-11-20 13:32:23 | Build failed in Jenkins: pgadmin4-master-python26 #511 |
Previous Message | Dave Page | 2017-11-20 13:31:06 | pgAdmin 4 commit: Display relevant error messages when access is denied |