Re: Patch for Feature #1344 Can't use multiple monitors (Windows 10)

Thanks, committed.

On Mon, Mar 27, 2017 at 5:09 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Dave
>
> On Mon, Mar 27, 2017 at 7:11 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> I've found a bug with this. When you set either of the options to True
>> for the very first time, then hit OK on the Preferences dialogue, the
>> setting is not stored. You have to go back into Preferences and set it
>> a second time.
>>
>
> I found this is an older issue when we add any new preferences
> setting(boolean type) which was not in SQLite database, it will store '1'
> instead of 'True/False' in the database. To reproduce this issue delete
> "pgadmin4.db" file and try to change any boolean value for example "Show
> system objects?", changes won't get reflected first time.
>
>>
>> From then on, it seems to be fine, so I wonder if we're failing to
>> store the config value the first time we insert a row for it, but
>> updates to it work fine.
>>
>> Can you take a look please?
>>
>
> Attached is the patch file to fix this issue. Can you please review
> it.
>
>>
>> Thanks.
>>
>> On Fri, Mar 24, 2017 at 10:45 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >
>> >
>> > On Fri, Mar 24, 2017 at 8:52 AM, Akshay Joshi
>> > <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>> >>
>> >> Hi All
>> >>
>> >> I have implemented Feature #1344 Can't use multiple monitors (Windows
>> 10).
>> >> Attached is the patch file. I did following things in this patch:
>> >>
>> >> Added "Open in New Browser Tab" preferences setting for "Query Tool"
>> and
>> >> "Debugger".
>> >> Use "window.open" and related functions to open the query tool and
>> >> debugger in other browser tab.
>> >>
>> >> I have tested it on Chrome, Firefox, Safari and Runtime. In Safari user
>> >> will have to uncheck "Block pop up window" settings.
>> >
>> >
>> > Thanks, applied.
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company