Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

Hi

On Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch to add SSL support for database connection.
> RM#2170
>
> Included test to check if current connection is using SSL or not
>

I think the SSL test needs a little work. Instead of:

Test for SSL connection check ... Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tests/test_check_ssl_connection.py",
line 42, in runTest
self.server['sslmode']
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 408, in skipTest
raise SkipTest(reason)
SkipTest: Cannot run SSL connection check test with 'prefer' sslmode
skipped "Cannot run SSL connection check test with 'prefer' sslmode"

I would expect to see:

runTest
(pgadmin.browser.server_groups.servers.tests.test_check_ssl_connection.TestSSLConnectionCheck)
Test SSL Connection ... skipped "Cannot run SSL connection check test with
'prefer' sslmode"
Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company