From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog |
Date: | 2016-04-07 10:14:56 |
Message-ID: | CA+OCxozu55OFo13kr_3K4DbCbGMCQ-NapvuX+zuFWNx08j0E=g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Thu, Apr 7, 2016 at 8:45 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA minor patch for PrivilegeRoleModel
>
> Change: Add check to disable PrivilegeRoleModel fields for nodes visible
> under catalog.
>
> Please review the patch.
I'm unclear what this is supposed to do:
- Those fields already seem to be disabled under catalog nodes (though
- the Add button on subnode grids is still active, but doesn't do
anything)
- Shouldn't we just hide privilege info on those nodes directly? Why
break modularity for this?
- I'm seeing weird effects after applying this patch - see the
attached screenshot. However, that issue remains even after I remove
it again (and restart the server, and hard-reload). It does seem to
fix itself eventually, but I'm not sure what causes that. If I try to
refresh the Functions node, I get:
jquery.contextMenu.js:309 No items specified to show in
contextMenuhandle.contextmenu @
jquery.contextMenu.js:309jQuery.event.dispatch @
jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333
jquery.contextMenu.js:312 Uncaught Error: No Items
specifiedhandle.contextmenu @
jquery.contextMenu.js:312jQuery.event.dispatch @
jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Surinder Kumar | 2016-04-07 10:22:32 | Re: [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog |
Previous Message | Arun Kollan | 2016-04-07 09:42:34 | Styling tab navigation and close buttons |