Re: Feature test regression failures

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Feature test regression failures
Date: 2017-03-16 10:48:44
Message-ID: CA+OCxozu1p0M=Z4B3ddOOApC42qG1FSdZFLnTtmzaEtLct0O4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> On Thu, Mar 16, 2017 at 3:55 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi Ashesh,
>>
>> A common theme is emerging from some of the feature test regression
>> failures on the Jenkins server. Please see:
>>
>> https://jenkins.pgadmin.org/job/pgadmin4-master-python27/ws/
>> web/regression/screenshots/EDB_Postgres_AS_9.3/ConnectsToSer
>> verFeatureTest-2017.03.16_10.09.18-Python-2.7.13.png
>>
>> I've very occasionally seen similar behaviour to this in the past - in
>> fact it's part of the reason why we grey out the UI until pgAdmin is
>> fully loaded.
>>
>> Any idea what might be causing it?
>>
> This can happen, when the module is not yet loaded for the respective
> node, and it is being expanded.
> Just thinking - shall we load all the javascript in the beginning?
>

That could be a lot of code, especially as the app grows. It may not be an
issue in the runtime (though, some recent reports would imply otherwise),
but it almost certainly would be on slower connections to installations
running in server mode.

There must be a way to ensure the code is loaded before we allow it to be
used?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-03-16 13:31:46 Re: [patch] Move to Alembic migration system
Previous Message Ashesh Vashi 2017-03-16 10:39:01 Re: Feature test regression failures