Re: [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken
Date: 2017-04-25 11:58:22
Message-ID: CA+OCxozrW_YNjrHRUC4qrzBkxLocVqmoBXnMH=NKxCrGn+0H2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ashesh, can you review/commit this please?

Thanks.

On Tue, Apr 25, 2017 at 10:18 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Fixed RM #2315 : Sorting by size is broken.
>
> Removed the pg_size_pretty function from query for the collection and
> introduced the client side function to convert size into human readable
> format. So, the sorting issue is fixed as the algorithm will get the actual
> value of size instead of formatted value.
>
>
> Thanks,
> Khushboo
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2017-04-25 13:10:51 pgAdmin 4 commit: Fixed handling of default parameters ordering in func
Previous Message Dave Page 2017-04-25 11:55:44 Re: [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions