Re: Trouble with requirement django-htmlmin

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Bruno Friedmann <bruno(at)ioda-net(dot)ch>
Cc: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Trouble with requirement django-htmlmin
Date: 2016-10-30 16:52:48
Message-ID: CA+OCxozqoEjEDKE8PbeF7MnwHb78pp_qsNT4gEtc3mKtz7vAJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Sunday, October 30, 2016, Bruno Friedmann <bruno(at)ioda-net(dot)ch> wrote:

> Hello there,
>
> I would like to know why the django-htmlmin module has been choosen
> compared
> to Flask-Htmlmin or simply htmlmin.
>

To be honest, because I didn't find Flask-Htmlmin when searching. It's also
worth nothing that that code is a little experimental. For example, it
won't work with the docs unfortunately (which needs fixing).

>
> The trouble, of django-htmlmin is that it tries to install and override
> htmlmin installation.
>

Urgh.

>
> I've open up a ticket upstream
> https://github.com/cobrateam/django-htmlmin/issues/107
> but no anwser.
>
> So my question would be, is it possible to consider a move to Flask-htmlmin
> of htmlmin (as pgAdmin4 is mostly a Flask apps) ?
>

Sure.

>
> What would be the best approach ?
>
> a) open a bug against pgAdmin 4
> b) create the needed patch
> c) send the patch
>

Yes - exactly that process :-)

>
> Thanks for your consideration, and hope to see most of you in Talinn.
>
>
I'll be there, see you soon.

Regards, Dave.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-30 17:16:47 Re: PATCH: To fix the issue in domain node (pgAdmin4)
Previous Message Bruno Friedmann 2016-10-30 16:39:08 Trouble with requirement django-htmlmin