Re: [pgAdmin4][Patch]: Load module's JS files only when required

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Load module's JS files only when required
Date: 2017-05-29 00:15:16
Message-ID: CA+OCxozps=GgHvXKJNJx3r9KUsn_g71jY4pRqR24gwP8cW-9ug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, May 26, 2017 at 12:01 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> On Fri, May 26, 2017 at 3:02 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Tue, May 23, 2017 at 4:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >
>> > I'm actually thinking that maybe it would be easier to start with the
>> > CSS files....
>>
>> Which i did yesterday. However, it soon became obvious that that isn't
>> so easy either, as the CSS files contain url references which need to
>> be adjusted, which isn't trivial.
>>
>> However, I did find a flask-webpack module, which looks interesting:
>>
>> https://github.com/nickjj/flask-webpack
>> https://nickjanetakis.com/blog/manage-your-assets-with-flask-webpack
>>
>> Surinder; when you have some free time, could you look into a simple
>> PoC with the CSS files using that please?
>
> Ok. I will look

BTW; if it looks like it will take a while to implement (as I
suspect), we should consider polishing off your initial patch as an
interim step. Any thoughts on how long RM2424 would take to resolve?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-05-29 00:21:47 Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Previous Message Dave Page 2017-05-28 23:51:51 Re: Autoformatting