Re: [pgAdmin4][patch]: RM 1967 - Layout is not remembered

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][patch]: RM 1967 - Layout is not remembered
Date: 2017-01-16 15:35:46
Message-ID: CA+OCxozprGRcduXiwRntSwGxqwHn0rZGs6k0NBY1oVgOAk8f4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed with a minor change to use an async request (I
think that removed the only remaining sync Ajax call we had left :-)
).

On Fri, Jan 13, 2017 at 10:55 AM, Neel Patel
<neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch file with the fix of RM #1967.
>
> Issue:-
> Sometime arranged layout is not getting remembered. This may be due to we
> were saving the layout on "unload" event and handling of "unload" event
> varies from different versions of browser so we should not listen "unload"
> event for saving layout.
>
> Solution:-
> Save the Layout on docker's "ATTACHED, DETACHED, MOVE_ENDED" event so that
> layout will be saved once user move the panel.
>
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-01-16 15:42:29 pgAdmin 4 commit: Handle comments on databases with datallowconn=False
Previous Message Dave Page 2017-01-16 15:35:00 pgAdmin 4 commit: Store layout changes on each adjustment, rather than