Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Could you update the 3.1 release notes to reflect that please?

On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Thanks patch applied.
>
> On Mon, May 7, 2018 at 12:16 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>> On Thu, May 3, 2018 at 9:02 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Thu, May 3, 2018 at 10:19 AM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>>
>>>> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Khushboo
>>>>>
>>>>> I have reviewed your code and looks good to me. Can we change the
>>>>> message from "The database name is inappropriate" to some meaningful
>>>>> message, so that user should know why it is inappropriate. If user will be
>>>>> able to create database with "=" in name then why Backup, Maintenance and
>>>>> Restore fails.
>>>>>
>>>>
>>> I changed the messages to read more like this: "Maintenance job creation
>>> failed. Databases with = symbols in the name cannot be maintained using
>>> this utility.".
>>>
>>> Changed.
>>
>>> However; I think that throwing the error when the user tries to execute
>>> the process is quite unhelpful, as the user may have spent some time
>>> choosing options etc. Can we do it when they open the dialogue (show the
>>> error instead of the tool's dialogue)?
>>>
>>> Done.
>>
>>> Thanks.
>>>
>>>
>>>>
>>>>> Thanks,
>> Khushboo
>>
>>> Done. Please find the attached updated patch.
>>>>
>>>>> On Wed, May 2, 2018 at 3:44 PM, Khushboo Vashi <
>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch which will fix RMs # 1220 and #1221.
>>>>>>
>>>>>> If the database name contains = then the backup, maintenance and
>>>>>> restore jobs are failing.
>>>>>> To fix these, we will display the error message regarding
>>>>>> inappropriate database name.
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company