Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

Thanks - patch applied.

On Tue, Jul 4, 2017 at 6:27 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached updated patch which includes following fixes:
>
> 1. The plus button to add a constraint with the domain dialogue doesn't
> work.
> 2. The Domain Constraint node doesn't load.
> 3. On update, the domain constraint node name doesn't change.
>
> Thanks,
> Khushboo
>
>
> On Mon, Jul 3, 2017 at 7:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, Jul 3, 2017 at 6:10 AM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Mon, Jul 3, 2017 at 1:10 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> The Domain Constraint module doesn't load as it can not find the
>>>> domain_constraints.js file.
>>>> To fix this issue, renamed the domain_constraint.js to
>>>> domain_constraints.js.
>>>>
>>>> RM #2529 <https://redmine.postgresql.org/issues/2529> created for the
>>> same.
>>>
>>>> Please find the attached fix.
>>>>
>>>>
>>>
>> I think this is still broken. If I try to create a new domain called abc,
>> with a basetype of text, then hit the + button to add a constraint, I get:
>>
>>
>> domain.js:24 Uncaught TypeError: Cannot read property 'server' of
>> undefined at s.initialize (domain.js:24) at s.e.Model (backbone-min.js:1)
>> at s [as constructor] (backbone-min.js:1) at new s (backbone-min.js:1)
>> at s._prepareModel (backbone-min.js:1) at set (backbone-min.js:1) at
>> s.add (backbone-min.js:1) at s.insertRow (backgrid.min.js:8) at
>> s.insertRow (backgrid.min.js:8) at HTMLButtonElement.<anonymous> (
>> backform.pgadmin.js:1347)
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company