| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4) |
| Date: | 2016-08-01 13:46:08 |
| Message-ID: | CA+OCxozkMUiTbd5yNNibmm4YBB2Zsyv=594EXj+NUMFgvvX4TQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Aug 1, 2016 at 2:33 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> We have to added it because postgres format_type() function do not provide
> us type with 'public' schema prefix to it, due to which wrong SQL's are
> getting generated.
> Rest other types are pre fixed with their respective schema as required.
OK, so:
# If schema is not pg_catalog & then add schema
if row['nspname'] == 'public':
rtn_type = row['nspname'] + "." + row['typname']
else:
rtn_type = row['typname']
?
!= pg_catalog is redundant with == public.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-08-01 14:10:56 | pgAdmin 4 commit: Use the same keyboard shortcuts in the query tool as |
| Previous Message | Murtuza Zabuawala | 2016-08-01 13:33:55 | Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4) |