From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | George Gelashvili <ggelashvili(at)pivotal(dot)io> |
Cc: | Atira Odhner <aodhner(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Acceptance Tests against a browser (WIP) |
Date: | 2017-01-27 16:28:41 |
Message-ID: | CA+OCxozeqDfoAiJ4AYf-Hnoq5FTCwWVXcEE-h460H5-_RVg9jw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Jan 27, 2017 at 4:11 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili
> <ggelashvili(at)pivotal(dot)io> wrote:
>> instead of that patch, please use this no-zombies version that kills the
>> started process group instead of pid-only.
>
> Very cool :-). The only minor annoyance for me is that my Mac pops up
> a message asking me if I want pgAdmin to accept connections, but
> there's nothing you can do about that of course.
>
> At this point I think there are a couple of things left to do;
>
> - Add more tests!
>
> - Add command line options to runtests.py to allow users to run either
> the existing tests or the acceptance tests (or both, which should be
> the default). Of course, it should still be possible to just run any
> single test.
Please add:
- Proper cleanup. I just noticed the tests have left an
"acceptable_test_db" database behind.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | George Gelashvili | 2017-01-27 16:38:05 | Re: [Patch] Refactor sql template version picking |
Previous Message | Dave Page | 2017-01-27 16:27:07 | Re: [Patch] Refactor sql template version picking |