Re: [pgAdmin4][Patch]: RM # 2895 - All the controls and display elements in the main window to be accessible using the tab key in an appropriate order

Thanks, patch applied.

On Fri, Feb 2, 2018 at 8:23 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Please find the attached updated patch.
>
> On Mon, Jan 29, 2018 at 3:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, Jan 29, 2018 at 9:00 AM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for RM #2895: As a keyboard user who has
>>> difficulty using a mouse, I need all the controls and display elements in
>>> the main window to be accessible using the tab key in an appropriate order.
>>>
>>> Key Notes:
>>> 1. While loading the application, all the focusable objects are
>>> accessible (Main menu, Right Panel, Left Panel)
>>> 1. Left hand side tree view is accessible via Alt+Shift+B
>>> 2. Right side tabbed panels are accessible via Alt+shift+[ and
>>> Alt+shift+]
>>> 3. Main menu navigation
>>> File Menu - Alt+Shift+F
>>> Object Menu - Alt+Shift+O
>>> Tools Menu - Alt+Shift+L
>>> Help Menu - Alt+Shift+H
>>> 4. Once the menu is opened, user can access the next/previous main menu
>>> through the left and the right arrow keys
>>> 5. When the user is in the SQL Editor and wants to change the panel, use
>>> ESC key to move the cursor out from the text editor and then can use the
>>> default shortcut keys (Alt+Shift+[ / Alt+Shift+])
>>>
>>
>> This seems to work quite well. I noticed a few issues in review thought:
>>
>> - The image added to the docs is the wrong size/resolution. Please see
>> Chethana to see how he generates them if needed.
>>
>> Fixed with the help of Chethana.
>
>> - The table in the docs has some extra + symbols still present where I
>> assume you copied/pasted an existing table and removed a column.
>>
>> Removed.
>
>> - Any reason why Alt+Shift+B isn't configurable?
>>
>> It is already there.
>
>> - I think the description for Alt+Shift+B should be "Focus the browser
>> tree".
>>
>> Changed.
>
>> - I don't see any Jasmine tests for the new JS, or any feature tests.
>> Whilst we needn't test every single option, I think we should at least test
>> that changing a shortcut works as expected, and of course, unit test the JS.
>>
>>
> Added Feature test for changing the shortcuts and the changes work as
> expected.
> As the new keyboard file is based on only events, couldn't write the
> Jasmine test for the same. In JS test, we give input and check the output
> on that bases, but here only events are registered and fired as per need.
>
> Thanks!
>>
>> Thanks,
> Khushboo
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company