From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Chris Mayo <aklhfex(at)gmail(dot)com> |
Cc: | "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH 1/2] Fix link to code_review in submitting_patches.rst |
Date: | 2016-10-10 08:33:34 |
Message-ID: | CA+OCxozdes15q2Hd0SBZOpax581uFYnRwUJiGwcP2YeU_oJqbA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
BTW, please send any future patches as attachments rather than inline, as I
had to apply this manually as it got munged in the email body.
Thanks!
On Sunday, October 9, 2016, Chris Mayo <aklhfex(at)gmail(dot)com> wrote:
> Signed-off-by: Chris Mayo <aklhfex(at)gmail(dot)com <javascript:;>>
> ---
> docs/en_US/submitting_patches.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_
> patches.rst
> index b4bbebe..9f8ab42 100644
> --- a/docs/en_US/submitting_patches.rst
> +++ b/docs/en_US/submitting_patches.rst
> @@ -29,7 +29,7 @@ might run::
> to create a patch between your development branch and the public master
> branch.
>
> Once you have your patch, check it thoroughly to ensure it meets the
> pgAdmin
> -:doc:`coding_standards`, and review it against the :doc:`code-review' to
> minimise
> +:doc:`coding_standards`, and review it against the :doc:`code_review` to
> minimise
> the chances of it being rejected. Once you're happy with your work, mail
> it to the
> `mailing list <mailto:pgadmin-hackers(at)postgresql(dot)org <javascript:;>>`.
> Please ensure you
> include a full description of what the patch does, as well as the
> rationale for
> --
> 2.7.3
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org
> <javascript:;>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-10-10 08:33:44 | Re: [PATCH 2/2] Improve references to the mailing list in docs |
Previous Message | Dave Page | 2016-10-10 08:32:25 | pgAdmin 4 commit: Fix mailto links and link to code_review doc. |