From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | Christoph Berg <myon(at)debian(dot)org>, pgAdmin support <pgadmin-support(at)postgresql(dot)org> |
Subject: | Re: [pgagent] patch: link with -pthread |
Date: | 2018-07-20 12:36:37 |
Message-ID: | CA+OCxozdZntntnmj=sxVg1TUfvQbpzA_TzWV_0jz3BsPr6rXpg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-support |
Thanks - looks good to me. Pushed to git.
On Fri, Jul 20, 2018 at 1:06 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:
> Hi Dave,
>
> Please find updated patch where we have linked "-pthread" library with x86
> and non-x86 linux.
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
> On Fri, Jul 20, 2018 at 4:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Fri, Jul 20, 2018 at 11:12 AM, Christoph Berg <myon(at)debian(dot)org> wrote:
>>
>>> Re: Dave Page 2018-07-20 <CA+OCxoxf5u3Ovf5yahei2RG-MA3C9jQLQ5vZ3q=
>>> isG5-Upf7Mg(at)mail(dot)gmail(dot)com>
>>> > Yes, at minimum I suspect. Does it complain if it's there on x86 Linux?
>>> > Christoph said he needed it on non-x86 archs.
>>>
>>> It's needed on non-x86 Linux, but does not complain on x86 (and I
>>> think it's good style to use it there as well).
>>>
>>
>> Fair point. Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-07-20 15:54:00 | Re: [pgagent] regression test |
Previous Message | Neel Patel | 2018-07-20 12:06:26 | Re: [pgagent] patch: link with -pthread |