From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Runtime refactoring |
Date: | 2020-07-27 12:25:20 |
Message-ID: | CA+OCxozdZHQ9dQwaS5NJ+6hBt5+GP687zXOJVXmjEmcu0nxh_A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Updated patch attached.
Thanks.
On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Dave
>
> The patch is not applied, can you please rebase and send again.
>
> On Fri, Jul 17, 2020 at 3:40 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> BTW, this will fix https://redmine.postgresql.org/issues/5490
>>
>> On Thu, Jul 16, 2020 at 10:41 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Here's a pretty large patch that implements a major refactoring of the
>>> runtime code. Specifically:
>>>
>>> - Move the bulk of the core code from main() into a new Runtime class.
>>> - Break up the mass of code that was main() into a number of relatively
>>> simple functions.
>>> - Make the Configuration dialog synchronous so the Log dialog can be
>>> properly viewed.
>>> - Enable/disable menu options at the right time.
>>> - Remove support for Qt < 5.0.
>>> - Remove the application name constant and hardcode the name to simplify
>>> the code.
>>> - Improve log messages.
>>> - Replace the sdbm hashing with Qt's MD5 hashing.
>>>
>>> Please review & test, but do not commit before next week's release.
>>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
Attachment | Content-Type | Size |
---|---|---|
Major_runtime_refactor_v2.patch | application/octet-stream | 64.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2020-07-28 05:20:22 | [pgAdmin][SonarQube] Rule - variable shadows a builtin |
Previous Message | Aditya Toshniwal | 2020-07-27 12:19:35 | Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React |