From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Cleanup handling of default/null values when data edi |
Date: | 2017-05-28 23:49:25 |
Message-ID: | CA+OCxozbEZVuUO13uL65vRrhi0+Tfs7CAofYyqZEe73X9W0HVw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Sun, May 28, 2017 at 1:25 PM, Harshal Dhumal
<harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> This commit has some performance issues with row paste functionality.
> For 2K copied rows with 3 columns (2 integer and one null column) it took
> near about 10 seconds to complete paste operation. And entire application
> becomes unresponsive for those 10 seconds.
>
> This is mainly because for each single pasted row entire grid is re-rendered
> ( is what I see in code).
> Ideally grid should be re-rendered only once after all rows are provided to
> grid.
>
> below code snippet from _paste_rows function
>
> _.each(copied_rows, function(row) {
> var new_row = arr_to_object(row);
> new_row.is_row_copied = true;
> row = new_row;
> self.temp_new_rows.push(count);
> grid.onAddNewRow.notify(
> {item: new_row, column: self.columns[0] , grid:grid}
> )
> grid.setSelectedRows([]);
> count++;
> });
>
> The statement
>
> grid.onAddNewRow.notify(
> {item: new_row, column: self.columns[0] , grid:grid}
> )
>
> causes grid to re-render (as we listener on onAddNewRow event where we
> re-render the grid)
Copying that number of rows is an extreme case of course, but still...
Is there an alternative way to batch notify?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-05-28 23:51:51 | Re: Autoformatting |
Previous Message | Harshal Dhumal | 2017-05-28 17:25:56 | Re: pgAdmin 4 commit: Cleanup handling of default/null values when data edi |