Re: Patch for Race Condition.

On Thu, Oct 3, 2013 at 12:59 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> I think - the fix may not work on every platform.
> We do unlock the mutex, which is not locked always.
>
> *diff --git a/pgadmin/frm/events.cpp b/pgadmin/frm/events.cpp*
> *index 359e372..1bc4b04 100644*
> *--- a/pgadmin/frm/events.cpp*
> *+++ b/pgadmin/frm/events.cpp*
> *@@ -791,6 +791,10 @@ void frmMain::OnSelRightClick(wxTreeEvent &event)*
> * s_currentObjectMutex.Lock();*
> * currentObject = browser->GetObject(item);*
> * }*
> *+ else*
> *+ {*
> *+ s_currentObjectMutex.Lock();*
> *+ }*
> * *
> * if (currentObject)*
> * doPopup(browser, event.GetPoint(), currentObject);*
>
>
Have you seen it fail? I did wonder about that myself, but it worked in
testing and as far as I could see the unlock was silently ignored when
appropriate.

>
> On Fri, Sep 27, 2013 at 8:22 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks - applied with minor changes to the comments and mutex name.
>>
>>
>> On Fri, Sep 27, 2013 at 8:51 AM, Dinesh Kumar <
>> dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> Sorry, it's my bad. The patch is build on another branch.
>>>
>>> Please find the attached patch which has been built on the pgAdmin
>>> master branch.
>>>
>>> Thanks in advance.
>>>
>>>
>>> Dinesh
>>>
>>> --
>>> *Dinesh Kumar*
>>> Software Engineer
>>>
>>> Ph: +918087463317
>>> Skype ID: dinesh.kumar432
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community> and
>>> more <http://www.enterprisedb.com/resources-community>
>>>
>>>
>>> On Thu, Sep 26, 2013 at 7:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>>
>>>>
>>>>
>>>> On Tue, Sep 24, 2013 at 12:37 PM, Dinesh Kumar <
>>>> dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Dave/Team,
>>>>>
>>>>> While working on one of the assigned task, i have been noticed the
>>>>> race condition on object "currentObject", which is concurrently updating
>>>>> by "onSelRightClick" and "execSelChange" methods. Due to this, sometimes, i
>>>>> am getting "n" Node context menu on "m" node.
>>>>>
>>>>> Ex:- When i right click on "server node", it is showing the "database
>>>>> node" popup menu options.
>>>>>
>>>>> I have been attaching the patch along with this request, and will be
>>>>> awaiting for your inputs.
>>>>>
>>>>
>>>> This doesn't apply - can you check the patch is correct please?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company