Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
Date: 2016-07-26 14:06:28
Message-ID: CA+OCxozYsK_aV5Gwh95-dm4m3HoeS8VS4KwX4Ds7PUXcvmH6eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, Jul 26, 2016 at 2:34 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch to fix encoding issue, I have tested in Python2/3 and
> looks like working in both environment.
>
> Almost all nodes are affected with this change, I tried to test & cover all
> basic operations on nodes but still it requires some testing.
>
> This patch will cover below tickets,
> RM#1307
> RM#1479

I've committed this as-is, as it fixes things nicely as far as I can
see... with one exception: I couldn't create Functions with utf-8
names. Can you fix that please?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-07-26 16:02:58 Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
Previous Message Dave Page 2016-07-26 14:05:17 pgAdmin 4 commit: Fix numerous encoding issues. Fixes #1307. Fixes #147