From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][RM#3121] Fix PEP-8 issues |
Date: | 2018-02-19 11:12:58 |
Message-ID: | CA+OCxozY=gJerLJSC60fE_rpbK8Z=2aP5jRvPQTfsZ0J_w8uBQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Feb 15, 2018 at 4:15 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Thank you for reviewing Joao.
>
>
> On Thu, Feb 15, 2018 at 8:37 PM, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Murtuza,
>> I just run this patch as you suggested(no errors reported) and also run
>> it through our CI pipeline and it look good
>>
>> Thanks
>> Joao
>>
>> On Wed, Feb 14, 2018 at 7:23 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the PEP-8 issues,
>>>
>>> To verify changes goto '../web' directory and run,
>>> pycodestyle --config=.pycodestyle ./regression/
>>> pycodestyle --config=.pycodestyle ./pgadmin/setup/
>>> pycodestyle --config=.pycodestyle ./pgadmin/settings/
>>> pycodestyle --config=.pycodestyle ./pgadmin/redirects/
>>> pycodestyle --config=.pycodestyle ./pgadmin/preferences/
>>> pycodestyle --config=.pycodestyle ./pgadmin/model/
>>> pycodestyle --config=.pycodestyle ./pgadmin/help/
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-02-19 11:17:46 | pgAdmin 4 commit: Add a marker (/*pga4dash*/) to the dashboard queries |
Previous Message | Dave Page | 2018-02-19 11:12:39 | pgAdmin 4 commit: Fix PEP8 issues in various modules. Fixes #3121 |