Re: PATCH: Added "Named restore point" functionality (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Added "Named restore point" functionality (pgAdmin4)
Date: 2016-05-11 15:15:56
Message-ID: CA+OCxozOxGwtYwyEGjt2fGqgmhb9nMi+Cn9QqS2=m_nXFYL-uA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Committed as is, but please submit a patch to disable the OK button,
until a name has been entered, to avoid accepting an empty name.

Thanks!

On Wed, May 11, 2016 at 11:59 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA updated patch with i18n support added in message.
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, May 11, 2016 at 3:50 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>> Hi,
>>
>> PFA updated patch for named restore point and I have also updated reload
>> configuration menu enable/disable condition as mentioned.
>>
>> Regards,
>> Murtuza
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, May 11, 2016 at 2:03 PM, Ashesh Vashi
>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>> On Wed, May 11, 2016 at 1:11 PM, Murtuza Zabuawala
>>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>>
>>>> PFA patch which will add "Adding named restore point" functionality on
>>>> server.
>>>
>>> Create named restore point is action restricted to the superuser only.
>>> Please check that in the menu enable/disable functionality.
>>>
>>> The check also applicable to 'relaod configuration'.
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-05-11 15:34:29 pgAdmin 4 commit: Fix menu width.
Previous Message Dave Page 2016-05-11 15:13:16 pgAdmin 4 commit: Allow creation of named restore points.