| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAmin4][Patch] - Kerberos support for Windows Installer |
| Date: | 2021-01-21 09:47:32 |
| Message-ID: | CA+OCxozOnj+RFycxhmmni-mYXAn-Jw58bwWgXnFMqDkrXimSnQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch to add the Kerberos support in the Windows
> installer script.
>
A couple of comments:
- The file names should be in lower case in the COPY lines. It will still
work of course, but for consistency and style...
- There's no check that the environment variable is set to a valid value.
For others, we have code block like:
IF NOT EXIST "%PGADMIN_QT_DIR%" (
ECHO !PGADMIN_QT_DIR! does not exist.
ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
EXIT /B 1
)
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2021-01-21 09:53:17 | pgAdmin 4 commit: Revert "Fixed an issue where shared server entries no |
| Previous Message | Dave Page | 2021-01-21 09:43:13 | Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted. |